refactor(cdk-experimental/radio-group): use shared example classes #31496
+21
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnermaciel
requested review from
crisbeto and
andrewseguin
and removed request for
a team
wagnermaciel
added
target: minor
|
Deployed dev-app for 155f3d2 to: https://ng-dev-previews-comp--pr-angular-components-31496-dev-n2vwe80a.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CDK experimental radio-group examples to leverage shared example utility classes, removing duplicated CSS rules and unifying markup across all examples.
- Stripped out custom stateful and disabled selectors from
radio-common.cssin favor of centralized shared example classes. - Updated each radio-group example HTML to add
.example-parenton the container and.example-stateful/.example-selectableon each radio button.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components-examples/cdk-experimental/radio-group/radio-common.css | Removed duplicated stateful/disabled CSS rules now provided by shared example classes. |
| src/components-examples/cdk-experimental/radio-group/cdk-radio-group-standard/.../example.html | Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>. |
| src/components-examples/cdk-experimental/radio-group/cdk-radio-group-readonly/.../example.html | Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>. |
| src/components-examples/cdk-experimental/radio-group/cdk-radio-group-horizontal/.../example.html | Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>. |
| src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled/.../example.html | Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>. |
| src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled-skipped/.../example.html | Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>. |
| src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled-focusable/.../example.html | Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>. |
| src/components-examples/cdk-experimental/radio-group/cdk-radio-group-configurable/.../example.html | Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>. |
| src/components-examples/cdk-experimental/radio-group/cdk-radio-group-active-descendant/.../example.html | Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>. |
Comments suppressed due to low confidence (2)
src/components-examples/cdk-experimental/radio-group/radio-common.css:25
- The background-color rule for disabled
.example-radio-groupwas removed; ensure the shared utility classes include equivalent styling so disabled groups remain visually distinguishable.
.example-radio-group[aria-disabled='true'] {
src/components-examples/cdk-experimental/radio-group/radio-common.css:77
- The opacity reduction for disabled radio button text was removed; verify that the shared example classes apply a clear disabled-state visual indicator for readability.
}
.../cdk-experimental/radio-group/cdk-radio-group-standard/cdk-radio-group-standard-example.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.